Bump deps and prep for release #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without bumping MSRV This can be updated to use the *std* implementation once our MSRV can be 1.70 or newer. For now this conservatively maintains the lower MSRV while dodging the undefined behavior of a mutable reference to a mutable static. Technically what we were doing would work, but relying on undefined behavior that we were only bending now breaking isn't a great practice. Two less unsafe blocks. Note the once_cell 1.21.x release series requires 1.66.0, which is a bump up from what fluent-pseudo currently needs.
alerque
commented
May 19, 2025
zbraniecki
approved these changes
May 19, 2025
This is still lower than the workspace MSRV for the other main crates (which is 1.67.0 as of now) so 1.65.0 shouldn't be a hinderance to anybody and allows current versions of both regex and once_cell.
alerque
force-pushed
the
release-prep
branch
2 times, most recently
from
8a1c156 to
6765dcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instigated by #381, but not yet adding new release versions since I'm reviewing the possibility of landing #373 first.