ADDS ALTAIR PLOT COMPONENT AND SOME OTHER FIXES #2644

nissu99 · 2025-01-26T06:35:31Z

- rename make_space_altair to something like make_altair_space_component
- add make_altair_plot_component
- Add support for all spaces. This means including the hexgrid and network transformation of the x and y coordinates.
- Have a generic get_agent_data method

@quaquel @EwoutH I’ve added a new component, make_altair_plot_component. Could you kindly check if it aligns well with the project?

P.S working on space support.

for more information, see https://pre-commit.ci

github-actions · 2025-01-26T06:43:06Z

Performance benchmarks:

Model	Size	Init time [95% CI]	Run time [95% CI]
BoltzmannWealth	small	🔵 +1.3% [+0.4%, +2.2%]	🔵 -0.3% [-0.5%, -0.2%]
BoltzmannWealth	large	🔵 -1.2% [-1.8%, -0.6%]	🔵 -0.5% [-1.6%, +0.7%]
Schelling	small	🔵 -0.7% [-1.0%, -0.5%]	🔵 +0.8% [+0.6%, +0.9%]
Schelling	large	🔵 -0.7% [-1.1%, -0.3%]	🔵 -0.9% [-1.3%, -0.5%]
WolfSheep	small	🔵 +0.1% [-0.1%, +0.3%]	🔵 +1.1% [+0.9%, +1.2%]
WolfSheep	large	🔵 +0.9% [+0.3%, +1.5%]	🔵 +1.9% [+1.2%, +2.5%]
BoidFlockers	small	🔵 -0.7% [-1.3%, -0.2%]	🔵 +1.8% [+1.6%, +2.0%]
BoidFlockers	large	🔵 -0.1% [-0.5%, +0.4%]	🔵 +1.9% [+1.6%, +2.3%]

EwoutH · 2025-01-26T10:42:39Z

Thanks for the PR! A few of the automated checks broke, could you look into what caused that?

I will leave the review to others.

tpike3 · 2025-01-26T13:17:47Z

@nissu99 also please look at #2643 and #2641 As you are @sanika-n are working in the same space

As it looks like you two are looking over the entire altair implementation I would also recommend looking at #2642 discussion

It is always good to collaborate and think together you may address some larger visualization challenges.

"alt defined"

for more information, see https://pre-commit.ci

nissu99 · 2025-01-27T08:04:19Z

@tpike3 When I run the tests locally, they don't fail, but they are failing here.

tpike3 · 2025-01-27T11:02:15Z

@tpike3 When I run the tests locally, they don't fail, but they are failing here.

I am not sure why your tests are passing locally, however for tests to pass they need to updated. It is expecting None and now getting Chart, because you added post process.

__ ERROR collecting tests/test_components_matplotlib.py _____________
tests/test_components_matplotlib.py:[20](https://github.com/projectmesa/mesa/actions/runs/12984364297/job/36207123671?pr=2644#step:6:21): in <module>
    from mesa.visualization.mpl_space_drawing import (
mesa/visualization/__init__.py:13: in <module>
    from .components import make_plot_component, make_space_component
mesa/visualization/components/__init__.py:7: in <module>
    from .altair_components import (
mesa/visualization/components/altair_components.py:93: in <module>
    post_process: Callable[[alt.Chart], alt.Chart] | None = None,
E   AttributeError: 'NoneType' object has no attribute 'Chart'

"removed a line"

"updated toml"

"removed suppress"

for more information, see https://pre-commit.ci

"doc string "

for more information, see https://pre-commit.ci

"operator bug"

nissu99 · 2025-01-27T18:41:24Z

@tpike3 When I run the tests locally, they don't fail, but they are failing here.

I am not sure why your tests are passing locally, however for tests to pass they need to updated. It is expecting None and now getting Chart, because you added post process.

__ ERROR collecting tests/test_components_matplotlib.py _____________
tests/test_components_matplotlib.py:[20](https://github.com/projectmesa/mesa/actions/runs/12984364297/job/36207123671?pr=2644#step:6:21): in <module>
    from mesa.visualization.mpl_space_drawing import (
mesa/visualization/__init__.py:13: in <module>
    from .components import make_plot_component, make_space_component
mesa/visualization/components/__init__.py:7: in <module>
    from .altair_components import (
mesa/visualization/components/altair_components.py:93: in <module>
    post_process: Callable[[alt.Chart], alt.Chart] | None = None,
E   AttributeError: 'NoneType' object has no attribute 'Chart'

Thank You, the issue got resolved by adding altair to the toml file.

nissu99 · 2025-01-30T18:40:03Z

@quaquel @tpike3 i was making a generic get_agent_data function ,should i remove all the old functions like _get_agent_data_new_discrete_space or keeping them will be right?

quaquel · 2025-01-30T19:20:59Z

Removing stuff that has become redundant is fine.

nissu99 · 2025-01-31T10:54:47Z

@quaquel i have added all the stuff,can you review it?

quaquel · 2025-01-31T11:14:23Z

I'll try to review it over the weekend, but I am rather bussy at the moment. This is a part of the code base I am not intimately familiar with and his been a while since I used Altair, so reviewing will take more time than parts of the code base I know inside out.

for more information, see https://pre-commit.ci

nissu99 · 2025-01-31T16:15:56Z

@tpike3 For now, there haven't been many conflicts with #2641. I have also talked to @sanika-n regarding possible overlaps ,will be looking forward for your review.

quaquel · 2025-02-02T19:36:16Z

I suggest we try to merge this PR first, then rebase #2643 and merge that afterward. @nissu99, @sanika-n do you both agree?

My motivation is that this overhauls the structure of the altair plotting API, while the other adds a feature to the API.

sanika-n · 2025-02-03T08:47:23Z

Sure, works for me

nissu99 · 2025-02-04T10:52:23Z

I suggest we try to merge this PR first, then rebase #2643 and merge that afterward. @nissu99, @sanika-n do you both agree?

My motivation is that this overhauls the structure of the altair plotting API, while the other adds a feature to the API.

Yes,why not.

quaquel · 2025-02-05T19:04:51Z

mesa/visualization/components/altair_components.py

-
-def _get_agent_data_new_discrete_space(space: DiscreteSpace, agent_portrayal):
-    """Format agent portrayal data for new-style discrete spaces.
+def get_agent_data(space, agent_portrayal):


For matplotlib, we use a slightly different approach in particular for networks and hexgrids: we update the location inside the respective plotting functions.

Would it be possible to have a single overarching get_agent_data method that is valid for both matplotlib and altair?

quaquel · 2025-02-05T19:05:19Z

mesa/visualization/components/altair_components.py

-        space: the mesa.experiment.cell_space.Grid instance
-        agent_portrayal: the agent portrayal callable
+        space: Mesa space object
+        agent_portrayal: Function defining agent visualization properties


please check the docs for get_agent_data in mpl_space_drawing

quaquel · 2025-02-05T19:05:57Z

mesa/visualization/components/altair_components.py

-        space: the ContinuousSpace instance
-        agent_portrayal: the agent portrayal callable
+    # New DiscreteSpace
+    if isinstance(space, Grid):


can you rewrite this to use case switch statements? See draw_space in mpl_space_drawing.

quaquel · 2025-02-05T19:06:57Z

Can you elaborate on the "other fixes" from the title?

nissu99 and others added 3 commits January 26, 2025 11:22

renamed make_space_altair

566b72f

added make_altair_plot_component support

e1f947c

[pre-commit.ci] auto fixes from pre-commit.com hooks

9e3a625

for more information, see https://pre-commit.ci

nissu99 changed the title ~~ADDS ALTAIR PLOT COMPONENT AND SOME OTHER FIXES #2435~~ ADDS ALTAIR PLOT COMPONENT AND SOME OTHER FIXES Jan 26, 2025

EwoutH added the visualisation label Jan 26, 2025

EwoutH requested review from Corvince and quaquel January 26, 2025 10:41

tpike3 mentioned this pull request Jan 26, 2025

added property_layer with altair #2643

Open

nissu99 and others added 3 commits January 27, 2025 13:15

Update altair_components.py

a88d816

"alt defined"

[pre-commit.ci] auto fixes from pre-commit.com hooks

c579f81

for more information, see https://pre-commit.ci

Merge branch 'main' into main

489c0fd

nissu99 and others added 7 commits January 27, 2025 23:30

Update altair_components.py

95a607b

"removed a line"

Update pyproject.toml

8e1779b

"updated toml"

Update altair_components.py

2b69a62

"removed suppress"

[pre-commit.ci] auto fixes from pre-commit.com hooks

b5613f1

for more information, see https://pre-commit.ci

Update altair_components.py

0d1b8be

"doc string "

[pre-commit.ci] auto fixes from pre-commit.com hooks

ed8ca71

for more information, see https://pre-commit.ci

Update altair_components.py

da8fd53

"operator bug"

nissu99 and others added 2 commits January 31, 2025 11:49

Merge branch 'main' into main

24210f4

blank

4a38eef

nissu99 and others added 3 commits January 31, 2025 19:29

resolved conflicts

c49f864

Merge branch 'main' into main

97de970

[pre-commit.ci] auto fixes from pre-commit.com hooks

0621810

for more information, see https://pre-commit.ci

Merge branch 'main' into main

7bdbc18

quaquel mentioned this pull request Feb 3, 2025

Added conditional checks for empty grid placement #2640

Open

quaquel reviewed Feb 5, 2025

View reviewed changes

Merge branch 'main' into main

a380bc6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADDS ALTAIR PLOT COMPONENT AND SOME OTHER FIXES #2644

ADDS ALTAIR PLOT COMPONENT AND SOME OTHER FIXES #2644

nissu99 commented Jan 26, 2025 •

edited

Loading

github-actions bot commented Jan 26, 2025

EwoutH commented Jan 26, 2025

tpike3 commented Jan 26, 2025 •

edited

Loading

nissu99 commented Jan 27, 2025 •

edited

Loading

tpike3 commented Jan 27, 2025

nissu99 commented Jan 27, 2025

nissu99 commented Jan 30, 2025 •

edited

Loading

quaquel commented Jan 30, 2025

nissu99 commented Jan 31, 2025

quaquel commented Jan 31, 2025

nissu99 commented Jan 31, 2025

quaquel commented Feb 2, 2025

sanika-n commented Feb 3, 2025

nissu99 commented Feb 4, 2025

quaquel Feb 5, 2025

quaquel Feb 5, 2025

quaquel Feb 5, 2025

quaquel commented Feb 5, 2025

ADDS ALTAIR PLOT COMPONENT AND SOME OTHER FIXES #2644

Are you sure you want to change the base?

ADDS ALTAIR PLOT COMPONENT AND SOME OTHER FIXES #2644

Conversation

nissu99 commented Jan 26, 2025 • edited Loading

github-actions bot commented Jan 26, 2025

EwoutH commented Jan 26, 2025

tpike3 commented Jan 26, 2025 • edited Loading

nissu99 commented Jan 27, 2025 • edited Loading

tpike3 commented Jan 27, 2025

nissu99 commented Jan 27, 2025

nissu99 commented Jan 30, 2025 • edited Loading

quaquel commented Jan 30, 2025

nissu99 commented Jan 31, 2025

quaquel commented Jan 31, 2025

nissu99 commented Jan 31, 2025

quaquel commented Feb 2, 2025

sanika-n commented Feb 3, 2025

nissu99 commented Feb 4, 2025

quaquel Feb 5, 2025

Choose a reason for hiding this comment

quaquel Feb 5, 2025

Choose a reason for hiding this comment

quaquel Feb 5, 2025

Choose a reason for hiding this comment

quaquel commented Feb 5, 2025

nissu99 commented Jan 26, 2025 •

edited

Loading

tpike3 commented Jan 26, 2025 •

edited

Loading

nissu99 commented Jan 27, 2025 •

edited

Loading

nissu99 commented Jan 30, 2025 •

edited

Loading