Skip to content

fix : prevent breakdown when citizen_density (Initial Agent Density s… #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colinfrisch
Copy link
Collaborator

πŸ› Bug fix

Noticed tiny bug on civil violence : the model breaks down when citizen_density (Initial Agent Density slider) is set to 0.
Fix is : model density starts now at 0.1

@colinfrisch colinfrisch added the bug Release notes label label Jun 24, 2025
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small πŸ”΅ +2.4% [+1.6%, +3.2%] πŸ”΅ +0.4% [+0.2%, +0.5%]
BoltzmannWealth large πŸ”΅ -0.3% [-0.7%, -0.0%] πŸ”΅ -0.4% [-0.8%, -0.0%]
Schelling small πŸ”΅ -0.0% [-0.2%, +0.1%] πŸ”΅ -0.2% [-0.4%, -0.0%]
Schelling large πŸ”΅ +0.7% [-0.8%, +3.0%] πŸ”΅ +0.2% [-0.3%, +0.7%]
WolfSheep small πŸ”΅ -0.3% [-0.5%, -0.1%] πŸ”΅ +0.2% [-0.1%, +0.4%]
WolfSheep large πŸ”΅ -0.6% [-1.2%, -0.3%] πŸ”΅ +0.9% [+0.3%, +1.6%]
BoidFlockers small πŸ”΅ +1.6% [+0.8%, +2.4%] πŸ”΅ +0.3% [-0.1%, +0.6%]
BoidFlockers large πŸ”΅ +1.7% [+1.0%, +2.3%] πŸ”΅ +0.7% [+0.5%, +0.9%]

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this, I think it makes sense.

I will leave the PR open for ~24 hours for additional comments/reviews.

Copy link
Member

@tpike3 tpike3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants