-
Notifications
You must be signed in to change notification settings - Fork 2
Remove unnecessary files #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
This is failing because the older workflows are triggered. |
authors: | ||
- name: Project Pythia Community | ||
url: https://projectpythia.org/ | ||
github: https://github.com/projectpythia-mystmd/wavelet-cookbook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to delete this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It (i.e. the config option) was just moved around. I was ordering things more similarly to the template cookbook. Doesn't really matter though.
Seems like you all have another PR working anyway so perhaps this whole PR can just get ignored.
site: | ||
options: | ||
logo: notebooks/images/logos/pythia_logo-white-rtext.svg | ||
folders: true | ||
template: book-theme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
template: book-theme |
@@ -23,9 +24,6 @@ project: | |||
- file: notebooks/example-workflows/nino3.ipynb | |||
jupyter: | |||
binder: | |||
repo: projectpythia-mystmd/wavelet-cookbook | |||
repo: projectpythia/wavelet-cookbook | |||
site: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole section really shouldn't be needed.
site: |
Removes older configuration files that are no longer needed.
I also noticed that a couple of images from Mathworks in the wavelet-basics notebook don't properly render with MyST because the files are missing an extension. That and something about the cookbook DOI were causing warnings in the MyST build, but otherwise things looked fine locally.