Fix #175 - doTransition error message fix #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsition state Signed-off-by: Nathan Gotz <[email protected]>
rufusnufus
pushed a commit
to KazanExpress/jiralert
that referenced
this pull request
May 13, 2024
…nsition state (prometheus-community#176) Signed-off-by: Nathan Gotz <[email protected]>
rufusnufus
added a commit
to KazanExpress/jiralert
that referenced
this pull request
May 13, 2024
* Better Jira error handling (prometheus-community#140) * Better Jira error handling * Return HTTP 400 Bad Request for non-retriable errors. It is inaccurate, but will prevent alertmanager from retrying. * Turns out go-jira does actually produce useful error messages (and it consumes the response body in the process). Log that instead of the empty body. Signed-off-by: Alin Sinpalean <[email protected]> * Also include HTTP response status 429 among retriable errors. Signed-off-by: Alin Sinpalean <[email protected]> * Include both the go-jira error and the response body in errors. Sometimes go-jira consumes the body and includes it in its error, sometimes it doesn't. Signed-off-by: Alin Sinpalean <[email protected]> --------- Signed-off-by: Alin Sinpalean <[email protected]> Co-authored-by: Alin Sinpalean <[email protected]> * disable update existing jira issues with parameter (prometheus-community#150) * Bump all dependencies (prometheus-community#133) Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: Holger Waschke <[email protected]> * parameter to disable update jira issues Signed-off-by: Holger Waschke <[email protected]> Signed-off-by: Holger Waschke <[email protected]> * rename parameter to make it more clear and avoid double negation. fix bug with missing return value. Signed-off-by: Holger Waschke <[email protected]> * Update main.go Signed-off-by: dvag-holger-waschke <[email protected]> * Update notify.go Signed-off-by: dvag-holger-waschke <[email protected]> * Update main.go Signed-off-by: dvag-holger-waschke <[email protected]> * Update main.go Signed-off-by: dvag-holger-waschke <[email protected]> * Update main.go Signed-off-by: dvag-holger-waschke <[email protected]> * Update notify.go Signed-off-by: dvag-holger-waschke <[email protected]> * fix for notify test Signed-off-by: Holger Waschke <[email protected]> --------- Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: Holger Waschke <[email protected]> Signed-off-by: Holger Waschke <[email protected]> Signed-off-by: dvag-holger-waschke <[email protected]> Co-authored-by: Jan-Otto Kröpke <[email protected]> Co-authored-by: Holger Waschke <[email protected]> * Adding getEnv templating function (prometheus-community#153) Signed-off-by: Jiri Tyr <[email protected]> * feat: add support for static jira labels (prometheus-community#154) Signed-off-by: Herman Ewert <[email protected]> Co-authored-by: Herman Ewert <[email protected]> * Fix prometheus-community#146 (safe limit of 200 characters from group label value) (prometheus-community#147) Signed-off-by: jzajic <[email protected]> * doc(PAT): Adds doc for PAT usage (prometheus-community#155) Signed-off-by: Julian Beck <[email protected]> * truncate descriptions that exceed -max-description-length (default 32KB) (prometheus-community#165) * truncate descriptions that exceed -max-description-length (default 32,768) Signed-off-by: Jason Wells <[email protected]> * Update main.go size was off by 1 Signed-off-by: Jason Wells <[email protected]> --------- Signed-off-by: Jason Wells <[email protected]> * fix: 🐛 Fixes error message for doTransition to display the proper transition state (prometheus-community#176) Signed-off-by: Nathan Gotz <[email protected]> * search for existing issue in multiple projects (prometheus-community#162) * search for existing issue in multiple projects Signed-off-by: Jason Wells <[email protected]> * Apply suggestions from code review Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Jason Wells <[email protected]> --------- Signed-off-by: Jason Wells <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]> * add Fingerprint field to Alert so that it may be used in templates (prometheus-community#152) (prometheus-community#163) Signed-off-by: Jason Wells <[email protected]> --------- Signed-off-by: Alin Sinpalean <[email protected]> Signed-off-by: Jan-Otto Kröpke <[email protected]> Signed-off-by: Holger Waschke <[email protected]> Signed-off-by: Holger Waschke <[email protected]> Signed-off-by: dvag-holger-waschke <[email protected]> Signed-off-by: Jiri Tyr <[email protected]> Signed-off-by: Herman Ewert <[email protected]> Signed-off-by: jzajic <[email protected]> Signed-off-by: Julian Beck <[email protected]> Signed-off-by: Jason Wells <[email protected]> Signed-off-by: Nathan Gotz <[email protected]> Co-authored-by: Alin Sinpalean <[email protected]> Co-authored-by: Alin Sinpalean <[email protected]> Co-authored-by: dvag-holger-waschke <[email protected]> Co-authored-by: Jan-Otto Kröpke <[email protected]> Co-authored-by: Holger Waschke <[email protected]> Co-authored-by: Jiri Tyr <[email protected]> Co-authored-by: Herman <[email protected]> Co-authored-by: Herman Ewert <[email protected]> Co-authored-by: Jan Zajic <[email protected]> Co-authored-by: Julian Beck <[email protected]> Co-authored-by: Jason Wells <[email protected]> Co-authored-by: Nathan Gotz <[email protected]> Co-authored-by: Bartlomiej Plotka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175 the error message for doTransition to display the proper state when logging an error.