feat(encoding)!: 🧁 encoding traits do not consume encoders #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
force-pushed
the
encode-mut-ref
branch
from
ca76c67
to
7d99951
Compare
|
i've refrained from bumping the |
cratelyn
force-pushed
the
encode-mut-ref
branch
from
7d99951
to
8175d61
Compare
|
i've also updated the benches, examples, and doctests so this should be ready for review now. 🔨 |
cratelyn
force-pushed
the
encode-mut-ref
branch
from
8175d61
to
99cc7c4
Compare
see prometheus#135. this adjusts the parameter of `encode()` so that it only mutably borrows the encoder. Signed-off-by: katelyn martin <[email protected]>
see prometheus#135. this adjusts the parameter of `encode()` so that it only mutably borrows the encoder. Signed-off-by: katelyn martin <[email protected]>
see prometheus#135. this adjusts the parameter of `encode()` so that it only mutably borrows the encoder. Signed-off-by: katelyn martin <[email protected]>
see prometheus#135. this adjusts the parameter of `encode()` so that it only mutably borrows the encoder. Signed-off-by: katelyn martin <[email protected]>
…eEncoder` see prometheus#135. this adjusts the parameter of `encode()` so that it only mutably borrows the encoder. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
encode-mut-ref
branch
from
99cc7c4
to
8833b0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #135.
this branch updates parameter types for different encoding traits:
EncodeLabel,EncodeLabelSet,EncodeMetric,Collector, andEncodeExemplarValue. rather than taking ownership of their respective encoder parameters, these now accept a&mutmutable reference.this allows for consumers of this API to e.g. compose label sets, loosens restrictions on field order in
#[derive(EncodeLabelSet)]structs, and provides a consistent signature type by following the pattern already set byEncodeLabelKey,EncodeLabelValue,EncodeGaugeValue, and other existing encoding traits.