-
Notifications
You must be signed in to change notification settings - Fork 2
von mises speedup #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can't speak to the correctness of the draw algo but if the 2sample test works 🤷. Just one change.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.19.0 #30 +/- ##
===================================================
- Coverage 80.86% 80.81% -0.06%
===================================================
Files 98 98
Lines 19595 19656 +61
Branches 19595 19656 +61
===================================================
+ Hits 15846 15885 +39
- Misses 3634 3656 +22
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Note:
vm_draw_test
is failing, and I'm not sure why.But two new tests are passing:
So for now the old test is commented out