Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shoot.py (Sourcery refactored) #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Sep 16, 2020

Pull Request #26 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/prono69/PepeBot pull/26/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Comment on lines -10 to +18
if not killed.text[0].isalpha() and killed.text[0] not in (
"/", "#", "@", "!"):
if await killed.get_reply_message():
await killed.edit(
"`Targeted user killed by Headshot 😈.. Bhag Bsdk`\n"
"#Sad_Reacts_Onli\n"
)
if (
not killed.text[0].isalpha()
and killed.text[0] not in ("/", "#", "@", "!")
and await killed.get_reply_message()
):
await killed.edit(
"`Targeted user killed by Headshot 😈.. Bhag Bsdk,patta se headshot`\n"
"#Sad_Reacts_Onli\n"
)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function killing refactored with the following changes:

  • Merge nested if conditions (merge-nested-ifs)

@pep8speaks
Copy link

Hello @sourcery-ai[bot]! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 16:80: E501 line too long (82 > 79 characters)

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Sep 16, 2020

Sourcery Code Quality Report (beta)

✅  Merging this PR will increase code quality in the affected files by 0.22 out of 10.

Quality metrics Before After Change
Complexity 4.00 2.00 -2.00 🔵
Method Length 46.91 45.91 -1.00 🔵
Quality 8.45 8.67 0.22 🔵
Other metrics Before After Change
Lines 11 13 2
Changed files Quality Before Quality After Quality Change
stdplugins/shoot.py 8.45 8.67 0.22 🔵

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Overall Recommendation

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants