Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema generator #1467

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fix schema generator #1467

wants to merge 10 commits into from

Conversation

almost-online
Copy link
Contributor

  • remove schema name from '_ids' and '_versions' column
  • add supporting the relative path in the external-schema

Sergiy Andrusenko added 2 commits February 27, 2018 09:55
@almost-online
Copy link
Contributor Author

@marcj I add the UT and fix UT issue

@dereuromark dereuromark added this to the Alpha 11 milestone Aug 3, 2020
@almost-online
Merge branch 'master' of git://github.com/propelorm/Propel2
a5f720c 
# Conflicts:
#	tests/Propel/Tests/Generator/Behavior/Versionable/VersionableBehaviorTest.php
@almost-online
FIX THE 1 MARKED SNIFF VIOLATIONS
c4fb56a 
410 | ERROR | [x] Expected 1 lines before "break", found 0.

     |       |     (SlevomatCodingStandard.ControlStructures.JumpStatementsSpacing.IncorrectLinesCountBeforeControlStructure)
@dereuromark
Copy link
Contributor

Thank you for reviving this old PR :)
Lets get it done and shipped 💪

@almost-online
Copy link
Contributor Author

@dereuromark
Just for closing my technical debt :)
Is any actions from me required?

@dereuromark
Copy link
Contributor

Did you check if any test can be added as regression protection?

@almost-online
Copy link
Contributor Author

Probably all possible tests was added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests Needed
Projects
None yet
Milestone
Alpha 11
Development

Successfully merging this pull request may close these issues.
3 participants
@almost-online @dereuromark @marcj