Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use parent:: instead of ModelCritera:: #2016

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

use parent:: instead of ModelCritera:: #2016

wants to merge 6 commits into from

Commits on Sep 13, 2024

  1. use parent:: instead of ModelCritera:: 

    As recommended in php docs http://php.adamharvey.name/manual/en/keyword.parent.php

Propel/Propel2 Issue 2009
    @rizwanjiwan
    rizwanjiwan committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3280819 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Test constraint on bookstore_id is redundant 

    Causing test to fail and doesn't add anything. bostore_contest.id is already in there, unique, and primary key.
    @rizwanjiwan
    rizwanjiwan committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2951a74 View commit details
    Browse the repository at this point in the history

  2. Check if matches are empty strings, not if they exist 

    Fix phpstan error.
    @rizwanjiwan
    rizwanjiwan committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    43dfc68 View commit details
    Browse the repository at this point in the history

  3. Revert "Check if matches are empty strings, not if they exist" 

    This reverts commit 43dfc68.
    @rizwanjiwan
    rizwanjiwan committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2a556f5 View commit details
    Browse the repository at this point in the history

  4. Check if matches are empty strings, not if they exist 

    Pass php stan?
    @rizwanjiwan
    rizwanjiwan committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3d244ef View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Work around phpstan thinking strlen returns >0 in all cases

    @rizwanjiwan
    rizwanjiwan committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fd21862 View commit details
    Browse the repository at this point in the history