fix timestampable use of datetimeclass #2017
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timestampable behavior doesn't use the
generator.dateTime.dateTimeClass
setting.I took a few liberties adressing this:
Propel\Generator\Builder\Om\ObjectBuilder
. For this it had to becomepublic
.PropelDateTime::createHighPrecision
expects the output ofmicrotime
to be formatted with a dot. This places the formatting in a separate (static) method.This allows keeping the updated_at and created_at microtimes in preInsert exactly the same value (instead of generating them independently).
I've avoided simplifying code to not break things.
What do you think?