Add protobuf_extra_deps.bzl for loading dependencies necessary for external repositories in protobuf_deps.bzl. #19418
+107
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_700448687
branch
3 times, most recently
from
966349b
to
12dfea5
Compare
…ternal repositories in protobuf_deps.bzl. This is needed for `rules_java` which requires additional loads for Bazel 8. This provides a single entrypoint for extra dependencies so we can add these moving forward without breaking users, and is similar to https://github.com/grpc/grpc/blob/master/bazel/grpc_extra_deps.bzl. Non-bzlmod users should make sure to set the following in their WORKSPACE file: ``` http_archive( name = "protobuf", strip_prefix = "protobuf-VERSION", sha256 = ..., url = ..., ) load("@protobuf//:protobuf_deps.bzl", "protobuf_deps") protobuf_deps() load("@protobuf//:protobuf_extra_deps.bzl", "protobuf_extra_deps") protobuf_extra_deps(); ``` PiperOrigin-RevId: 700448687
copybara-service
bot
force-pushed
the
test_700448687
branch
from
12dfea5
to
235897e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add protobuf_extra_deps.bzl for loading dependencies necessary for external repositories in protobuf_deps.bzl.
This is needed for
rules_javawhich requires additional loads for Bazel 8. This provides a single entrypoint for extra dependencies so we can add these moving forward without breaking users, and is similar to https://github.com/grpc/grpc/blob/master/bazel/grpc_extra_deps.bzl.Non-bzlmod users should make sure to set the following in their WORKSPACE file: