Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s): handle Kubernetes kubeconfig content correctly #5939

Merged

Conversation

MrCloudSec
Copy link
Member

@MrCloudSec MrCloudSec commented Nov 27, 2024

Description

  • Ensured the SDK uses consistent Kubernetes credentials regardless of whether the kubeconfig is provided as a multi-line string or a file.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added provider/kubernetes Issues/PRs related with the Kubernetes provider component/ui component/api labels Nov 27, 2024
@MrCloudSec MrCloudSec added the backport-to-v4.6 Backport PR to the v4.6 branch label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.92%. Comparing base (bcf1ef1) to head (49446a7).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...rowler/providers/kubernetes/kubernetes_provider.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5939      +/-   ##
==========================================
- Coverage   89.93%   89.92%   -0.02%     
==========================================
  Files        1147     1147              
  Lines       35599    35608       +9     
==========================================
+ Hits        32017    32020       +3     
- Misses       3582     3588       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec marked this pull request as ready for review November 28, 2024 17:34
@MrCloudSec MrCloudSec requested review from a team as code owners November 28, 2024 17:34
api/src/backend/api/models.py Outdated Show resolved Hide resolved
Copy link
Member

@paabloLC paabloLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment on the CustomInput component.

ui/components/ui/custom/custom-input.tsx Outdated Show resolved Hide resolved
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix @MrCloudSec 👏

@MrCloudSec MrCloudSec dismissed stale reviews from paabloLC and vicferpoy November 29, 2024 12:51

UI changes are not needed at the end.

@MrCloudSec MrCloudSec merged commit c1d6021 into master Nov 29, 2024
9 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5496-review-behavior-of-kubernetes-credentials branch November 29, 2024 13:31
prowler-bot pushed a commit that referenced this pull request Nov 29, 2024
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Nov 29, 2024
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v4.6 Backport PR to the v4.6 branch provider/kubernetes Issues/PRs related with the Kubernetes provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants