-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(k8s): handle Kubernetes kubeconfig content correctly #5939
fix(k8s): handle Kubernetes kubeconfig content correctly #5939
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5939 +/- ##
==========================================
- Coverage 89.93% 89.92% -0.02%
==========================================
Files 1147 1147
Lines 35599 35608 +9
==========================================
+ Hits 32017 32020 +3
- Misses 3582 3588 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment on the CustomInput component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix @MrCloudSec 👏
UI changes are not needed at the end.
(cherry picked from commit c1d6021)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Description
kubeconfig
is provided as a multi-line string or a file.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.