Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for Mintemp/Maxtemp errors before running autoload #2609

Closed
wants to merge 4 commits into from
Closed

Add check for Mintemp/Maxtemp errors before running autoload #2609

wants to merge 4 commits into from

Conversation

awenelo
Copy link
Contributor

@awenelo awenelo commented Apr 16, 2020

During a Mintemp error, if the filament sensor newly detects the presence of filament (filament sensors state goes from 0 to 1) the Autoload preheat menu no longer opens.

This fixes #2605

Tests:

  • Compiled with PF-build.sh
  • Turned on printer and inserted filament, Autoload still runs.
  • Unplugged Hotend thermistor, waited for Mintemp to trigger. Inserted filament. Autoload Didn't run.
  • Shorted Hotend thermistor connection on board, waited for alarm(Maxtemp). Inserted filament. Autoload Didn't run.
  • Unplugged Heatbed thermistor, waited for Mintemp to trigger. Inserted filament. Autoload Didn't run.
  • Shorted Heatbed thermistor connection on board, waited for Maxtemp to trigger. Inserted filament. Autoload Didn't run.

@awenelo awenelo changed the title Added check for Mintemp/Maxtemp errors before running autoload Add check for Mintemp/Maxtemp errors before running autoload Apr 16, 2020
awenelo2 and others added 3 commits April 19, 2020 17:07
@awenelo
Copy link
Contributor Author

awenelo commented Aug 2, 2020

Closing in favour of #2788, which checks more possibilities.

@awenelo awenelo closed this Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Autoload procedure can trigger during mintemp
1 participant