-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to paho-mqtt 2.1.0 #405
Conversation
It might be possible to allow the paho client to be >= 1.6.1 and <=3.00. This way it does not break fro users that still depend on the old client. For example: Python-roborock/python-roborock#288 |
Good point. |
@Tabisch It seems the CI test is failing because of the state of |
All the CI test logs told me to run |
CI passed. |
Sorry that you have to rerun the workflow. |
Erm why did you set the readme executable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash (and sign) your commits
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be completely honest i did this, because git was telling me that i had nothing to commit.
I only do this stuff as a hobby and don't really know my way around git that well.
Gonna look into this.
Sorry that im making this such a hassle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be change it back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrote that while i was at work.
Just came back.
I guess i was more an obstacle that a help.
I hope this is correct now. |
@pschmitt Can you have another look at this one. It is currently blocking home-assistant/core#136130 It would be nice to see the lib to be bumped to a version that included this changes. |
Sure |
Thanks! |
Hi,
i wanna help get this PR in home-assistant get done.
home-assistant/core#136130
As far as i understand the paho-mqtt documentation, bumping the version and adding CallbackAPIVersion.Version1, when creating the Client object should be enough.
https://eclipse.dev/paho/files/paho.mqtt.python/html/migrations.html
You might want to remove types-paho-mqtt, because it isnt needed anymore.
https://pypi.org/project/types-paho-mqtt/1.6.0.20240321/
I cant test this, because i dont own a roomba.
Thank you.