-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mix_stderr parameter was removed from click 8.2.0 #4577
Conversation
Thanks for the contribution! |
Also, wouldn't this change make the entire class redundant? |
Yes, seems like we may have to make this conditional on Click version. |
Ok, I will try to make it conditional 🙂 |
sorry, I couldn't think of a more pythonic way |
for more information, see https://pre-commit.ci
tests/test_black.py
Outdated
@@ -114,7 +116,10 @@ class BlackRunner(CliRunner): | |||
"""Make sure STDOUT and STDERR are kept separate when testing Black via its CLI.""" | |||
|
|||
def __init__(self) -> None: | |||
super().__init__(mix_stderr=False) | |||
if Version(imp_version('click')) >= Version('8.2.0'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if Version(imp_version('click')) >= Version('8.2.0'): | |
if Version(imp_version("click")) >= Version("8.2.0"): |
CI is unhappy because the quotes get reformatted to double quotes, but I think it should be gtg after this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
From click 8.2.0 changelog:
so
mix_stderr=False
throws an error and is redundant.