fix: adjust timing of storage retrieval due to race conditions #90
+21
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is working much smoother overall, but I notice that the "swipe" to favorite/unfavorite is still a little sketchy. I dunno if it is used, but it is reproducible in a browser by click-hold-sliding left. |
ewdurbin
approved these changes
Mar 13, 2025
ewdurbin
reviewed
Mar 13, 2025
JacobCoffee
force-pushed
the
favorites-caching
branch
from
7c6e384 to
293b539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
storage.getreturns a promise but we don't await the result and just immediately returned the favorites of that user so it would take some refreshes for things to take effect... or something.Move the things inside of the
then's so it waits for the data