Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unified key for easy yearly rotation #92

Closed
wants to merge 1 commit into from

Conversation

JacobCoffee
Copy link
Member

  • Adds yearly key prefix that can be changed each year easily instead of having to change the key each year in a bunch of places
  • Adds helper abstractions to easily deal with this prefix

@JacobCoffee JacobCoffee requested a review from ewdurbin March 14, 2025 16:00
@JacobCoffee
Copy link
Member Author

@ewdurbin is this along the right path? if so i can do all the replacements for this.storage.$verb

@ewdurbin
Copy link
Member

Huh, I wonder if it could be as simple as updating the way we initialize our storage to change the name to be pyconus2025

https://github.com/ionic-team/ionic-storage?tab=readme-ov-file#angular-configuration

We call the initializer in a few places but it seems like consolidating those would be wise. https://github.com/search?q=repo%3Apsf%2Fpycon-us-mobile+IonicStorageModule.forRoot&type=code

that might ultimately be the cleanest solution.

ewdurbin added a commit that referenced this pull request Mar 19, 2025
Closes #66

Supersedes #91
Supersedes #92
@ewdurbin ewdurbin mentioned this pull request Mar 19, 2025
@JacobCoffee
Copy link
Member Author

#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants