syscon: Use known/documented function names #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Do you have some code that would allow for this to be tested? |
I don't exactly have a sample, but I do use a lot of these in PSP-Everest: https://github.com/joel16/PSP-Everest/blob/main/plugin/kernel/kernel.c |
|
maybe could use explanations about what pommel and baryon are ? |
IMO I don't think that fits in SDK documentation. The SDK just explains what the functions do (info on return values and arguments used). The wiki has that information: Baryon: https://www.psdevwiki.com/psp/Baryon |
sharkwouter
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on reverse-enginnered code by @Felix-Dev from uOFW (https://github.com/uofw/uofw/blob/power/include/syscon.h). I have also added punctuation on some of the existing documentation.