Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Zope 4.0 #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

carloshanson
Copy link

After installing Zope 4.0, I had some trouble getting ZPsycopgDA to work. These are the changes I made to get it to work.

chansonit and others added 2 commits July 5, 2017 11:49
Added Products.ZSQLMethods as a prerequisite.  Added detailed instructions for a new installation of Zope 4.0 using virtualenv.
@tobiasherp
Copy link

Will this work for Zope2 as well?
If not, please put it in a new version branch; we need a released version 2.4.7 quite badly ... (#8)

@tobiasherp
Copy link

Seems to be OK; tried the import with Zope2 v2.13.22

$ ./bin/pip install git+https://github.com/zopefoundation/Products.ZSQLMethods.git
$ ./bin/pip install git+https://github.com/psycopg/ZPsycopgDA.git
$ cd lib/python2.7/site-packages/Products
$ ln -s /path/to/virtualenv/lib/python2.7/site-packages/ZPsycopgDA .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect these instructions to be useful for the current "zipped distribution"; however, we should "eggify" ZPsycopgDA as Products.ZPsycopgDA, and this would make the package installable the standard way (via pip or buildout), obsoleting the instructions.

Thus, my suggestion would be to merge this change to a new zipped branch, and go for the egg in a new eggified branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasherp Are there obsolete instructions in the readme? About MR #7 I see that the url http://zope.readthedocs.io/en/latest/INSTALL-virtualenv.html is broken. can that MR be just closed?

@dvarrazzo
Copy link
Member

@tobiasherp do you think it's a good idea to cherry-pick the changeset b50b8cc and drop MR #7?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants