Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebglDistort for GIF's #1614

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WebglDistort for GIF's #1614

wants to merge 2 commits into from

Conversation

ataata107
Copy link

@ataata107 ataata107 commented Feb 4, 2020

Concerns #1470 (<=== Replace 0000 with the Issue Number)
ezgif com-video-to-gif

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #1614 into main will increase coverage by 0.04%.
The diff coverage is 9.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1614      +/-   ##
==========================================
+ Coverage   66.67%   66.72%   +0.04%     
==========================================
  Files         130      130              
  Lines        2686     2687       +1     
  Branches      433      433              
==========================================
+ Hits         1791     1793       +2     
+ Misses        895      894       -1
Impacted Files Coverage Δ
src/modules/WebglDistort/Module.js 4.54% <9.52%> (+2.24%) ⬆️

@rishabhshuklax rishabhshuklax changed the title [WIP] Webgl for GIF's WebglDistort for GIF's Feb 4, 2020
@ataata107
Copy link
Author

ataata107 commented Feb 4, 2020

Woohoo WebGL is also now working for gif's
@publiclab/is-reviewers

@rishabhshuklax
Copy link
Member

@ataata107 could you share the cli output, thanks!

@harshkhandeparkar harshkhandeparkar added the almost-complete PRs that are almost done but little more work. label Jul 27, 2021
@harshkhandeparkar harshkhandeparkar marked this pull request as draft July 27, 2021 21:16
@harshkhandeparkar harshkhandeparkar removed the almost-complete PRs that are almost done but little more work. label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants