-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v3.6.0 for new npm release #1695
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1695 +/- ##
===========================================
+ Coverage 55.11% 65.43% +10.31%
===========================================
Files 117 133 +16
Lines 2344 2743 +399
Branches 360 439 +79
===========================================
+ Hits 1292 1795 +503
+ Misses 1052 948 -104
|
Cool. Let's release it! Pushing to beta. |
Has it been 13 months? Wow! We need to publish sooner... |
@harshkhandeparkar yes we do! This Gitpod thing plus all the fantastic UI testing we have will make this easier -- #1000, more specifics here: #1369. I'd like to call for more UI testing to be implemented, to further secure our base feature set, as well as ask for any help with the #1694. |
Can you wait before my latest PR gets merged? |
Before releasing this one? Sure, which PR? |
I'd also like to try to set a new requirement that any new feature has:
That'll help us stabilize things a lot from here out! |
#1696, part of bug stomp feb, yet I opened the PR in July 😂 |
@harshkhandeparkar why don't we just release |
Hmm. only |
Looks like a timeout when fetching deps. Restarted. (Fixed!) |
Sure. I forgot to add the tests actually 😅 |
OK, let's do this!!! Releasing as |
Wait, i need to coordinate building this and the new script at #1703... hang on... |
@jywarren check out the new project I opened. |
Sure, ok! You mean after this is merged. What other PRs should we try to merge before this, or should we just go ahead with 3.6.0 and do others in a follow-up? |
This is ready for merge unless @publiclab/is-maintainers want some other PR/issue to be fixed (in which case, add it to the v3.6.0 project) :) |
Agreed, I merged or approved a couple dependabot prs so we can merge this after! |
OK, running final update! |
Merged! Let's publish
How does this look? |
Umm, we don't add dist files to the |
Also, the team discussions are turned off, is that intentional? If not, we can make these checklists there ig... |
Yes, i've found it's quite hard to find the team discussions as they don't work the same way as issues. I prefer to use issues for all discussions, which i feel is more transparent, sound good? Thanks Harsh! The steps i noted prob need to be reordered and corrected -- can you edit my comment or copy it? I think we should keep a standard checklist for each release! |
Maybe we can do a template, which we use to run the release process from within. It seems GitHub doesn't do multiple pull requests templates, but we could run the release within an issue using an issue template, and that makes sense anyways because there are steps /after/ merging the pull request, so the issue would stay open until the very end of the checklist. How does that sound? |
This accounts for a TON of changes over the past 13 months. Compiling some highlights:
I am surely missing a ton here. But much appreciation to the following contributors during this period:
@keshav234156 @blurry-x-face @aashna27 @harshkhandeparkar @root00198 @ataata107 @tech4GT @anthony-zhou @Divy123 @VladimirMikulic @Ryan10145 @tsparksh @yottabytedev @vgadodia @vaibhavmatta @tudoranghelina91 @sanjana091001 @samagragupta @pythongiant @ovsundal @ojurkiewicz @nisarhassan12 @niravasher @kirito-k @johanuribe03 @ikayz @freerangeandy @duyquangnguyenhac @dnhuan @arghac14 @Olusamimaths @Deogle @28-ys @sashadev-sky @bhavayAnand9
Please feel free to chime in with big updates to be added to the changelog if you like! 🎉
And, try out our new GitPod integration allowing us to more quickly and effectively review PRs due to on-the-fly interactive builds for each PR pushed up.