-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase migrations in preparation for pulpcore 3.70. #3829
Conversation
@ggainey How should we handle squashing? I'd be OK if we went ahead and did that for the upcoming release, to go alongside pulpcore 3.70 |
Assuming we take the same approach, we'd want to squash migrations up through rpm/3.17 (0001 thru 0040? I think?) the way core does for up to core/3.20, here : https://github.com/pulp/pulpcore/pull/6024/files#diff-b69496c4630640d3ca417ef201dd32986671d2e13dbc6d9e901decb490ff8718 |
As its own PR, btw - this PR adapts us to the pulpcore changes. |
3.17.0 is nearly 3 years old, when we squashed up to pulpcore 3.20, that's actually about 6 months newer than 3.17. TBH, we have no new migrations since the last major release - which was actually 6 months ago. I'm pretty sure we can squash them entirely (but not delete the existing ones immediately). Plugins are not really the same as Pulpcore, nothing but Pulp RPM depends on Pulp RPM migrations. |
I realized, after some experimentation, that, if we go for deleting the |
I think we're saying the same thing? I'm contending that we'd squash up through 3.17, because rpm/3.18-core/3.21 are used together by several downstreams, so rpm/3.17 is the "newest rpm used with core/3.20 or earlier". I'd just like to see this PR be only "adapt to the pulpcore squash", and have a separate, later, PR, be "squash rpm up thru 3.17". Does that make sense? |
My thought was always that we would squash plugin migrations before doing so for pulpcore. It simplifies everything quite a bit because at that point you know that nothing depends on those migrations (except for a 3rd party plugin I guess) |
2eb8c3d
to
d4475e1
Compare
closes #3828.