-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URL encoding issue in pulp_file #5835
Conversation
c267552
to
66f87e3
Compare
I modified the change to not apply to Now all that is missing is a unit test. Although, to make it easy to write a unit test we probably need to split some of this out into a separate method. I don't think writing a unit test for the entire |
Added unit tests rather than changing how the pytest fixture webserver serves the files which seems messy to begin with. The test matrix is rather long but since the tests run very quickly I don't see the harm in being thorough :) |
+1 to putting this in a helper method. I guess without it would have been pretty messy to unit test. 😆 |
Backport to 3.63: 💚 backport PR created✅ Backport PR branch: Backported as #5991 🤖 @patchback |
closes #5686
Simiilar to https://github.com/pulp/pulp_deb/blob/b146fad9d894aeab89fe583a4fb60220a270744f/pulp_deb/app/tasks/synchronizing.py#L623 to quote the URL path.