Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL encoding issue in pulp_file #5835

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix URL encoding issue in pulp_file #5835

merged 1 commit into from
Oct 8, 2024

Conversation

sbernhard
Copy link
Contributor

@sbernhard sbernhard commented Sep 24, 2024

@quba42
Copy link
Contributor

quba42 commented Sep 26, 2024

I modified the change to not apply to file:// URLs (because this would break them).

Now all that is missing is a unit test. Although, to make it easy to write a unit test we probably need to split some of this out into a separate method. I don't think writing a unit test for the entire FileFirstStage.run() method is what we want.

@hstct
Copy link
Contributor

hstct commented Oct 1, 2024

Added unit tests rather than changing how the pytest fixture webserver serves the files which seems messy to begin with.

The test matrix is rather long but since the tests run very quickly I don't see the harm in being thorough :)

@quba42
Copy link
Contributor

quba42 commented Oct 1, 2024

+1 to putting this in a helper method. I guess without it would have been pretty messy to unit test. 😆

@ggainey ggainey merged commit 0d3b421 into pulp:main Oct 8, 2024
12 checks passed
@quba42 quba42 deleted the fix_5686 branch October 8, 2024 12:48
Copy link

patchback bot commented Nov 10, 2024

Backport to 3.63: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.63/0d3b42171e305a4e9b8cb29b1cc1c4cd32ef93b8/pr-5835

Backported as #5991

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulp_file fails to sync file repos literally containing URL encoding strings like %3a in a file name
4 participants