Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Bump macOS runner images from macos-12 to macos-13 #1120

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Oct 26, 2024

Summary

The macOS 12 runner image will be end-of-life for GitHub Actions by early December 2024. Switch to the macOS 13 image now, ahead of when we would be voluntold to.

We are beginning the deprecation process for the macOS 12 runner image
[ . . . ] This image will be fully retired by the December 3rd, 2024.

https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

Verification Process

CI will run, hopefully it will pass right away, if not, this PR will let me test fixes until something works.

The macOS 12 runner image will be end-of-life for GitHub Actions
by early December 2024. Switch to the macOS 13 image now,
ahead of when we would be voluntold to.

> We are beginning the deprecation process for the macOS 12 runner image
> [ . . . ] This image will be fully retired by the December 3rd, 2024.

https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Oct 27, 2024

This result is no worse than with the macos-12 runner image.

Working on the remaining issue (which is keeping this PR's CI red but is an unrelated issue also equally affecting master branch)... at #1121, for now.

But this did well enough that we can safely merge it, IMO. Again, it's no worse than what we already have, and extends our support lifetime out a bit.

@savetheclocktower
Copy link
Contributor

Only editor test that fails is the notoriously flaky one. I'm 👍 on this.

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Nov 4, 2024

Thanks for review, merging!

@DeeDeeG DeeDeeG merged commit 970f83c into master Nov 4, 2024
102 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants