Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bucket references to BucketV2 #13011

Merged
merged 60 commits into from
Nov 9, 2024
Merged

Update Bucket references to BucketV2 #13011

merged 60 commits into from
Nov 9, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Oct 2, 2024 •
edited
Loading

Proposed changes

Update references to aws.s3.Bucket with aws.s3.BucketV2, just as we would like our users to do.

Out of scope

Content with onObjectCreated and similar overlays

There is a bit of a migration gap for this content we need to think through: #13014

Policy (cross-guard)

Separating this out as it requires extra effort: #13013

Shortcodes and Layouts

I have found the following references to Bucket but was not sure how these features work to update them safely:

layouts/page/crossguard.html
layouts/partials/home/cli.html
layouts/partials/home/console.html
layouts/partials/home/ide.html
layouts/shortcodes/pulumi-bucket.html
layouts/shortcodes/pulumi-new-bucket.html

Related issues (optional)

Related to https://github.com/pulumi/home/issues/3633

@interurban interurban requested a review from cnunciato October 2, 2024 17:14
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 2, 2024

There is still a little bit of content here that's update-able but entangled with ACLs and websites, that doesn't work very well anymore due to AWS changes. I'm going to try to get it over the finish line tomorrow:

** TODO content/docs/iac/concepts/how-pulumi-works.md
** TODO content/docs/iac/get-started/aws/deploy-changes.md
** TODO content/docs/iac/get-started/aws/deploy-stack.md
** TODO content/docs/iac/packages-and-automation/automation-api/getting-started-automation-api.md

@t0yv0 t0yv0 requested review from flostadler and corymhall October 5, 2024 00:29
@t0yv0 t0yv0 force-pushed the t0yv0/update-to-bucketv2 branch from 8f573c8 to a57d1f6 Compare October 17, 2024 18:17
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 3314e42 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13011-3314e427.s3-website.us-west-2.amazonaws.com.

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 17, 2024

#13142 takes care of how-pulumi-works page.

@t0yv0 t0yv0 marked this pull request as ready for review October 18, 2024 16:21
@t0yv0 t0yv0 requested a review from a team as a code owner October 18, 2024 16:21
@mjeffryes mjeffryes added this to the 0.112 milestone Oct 30, 2024
@t0yv0 t0yv0 requested review from thoward and sean1588 and removed request for cnunciato October 31, 2024 20:17
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 5, 2024

Let me rebase and follow up on these, thanks so much!

@t0yv0 t0yv0 requested a review from sean1588 November 5, 2024 18:21
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 5, 2024

Added the suggested edits, rebased on master and excluded conflicting pulumi_org_search.md , PTAL.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 79e7fac is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13011-79e7faca.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 5d12131 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13011-5d121317.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit cdeac5b is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13011-cdeac5be.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 961bf86 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13011-961bf864.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit e7f28bd is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13011-e7f28bd1.s3-website.us-west-2.amazonaws.com.

t0yv0 added 2 commits November 8, 2024 16:19
@t0yv0
Reverting content/migrate/terraform.md
e55bb94 
This cannot work with BucketV2 yet because of onObjectCreated support

See: pulumi/pulumi-aws#4475

Reminder in: pulumi/home#3736

However when verifying the content it was found to not compile; fixing that.
@t0yv0
Fix typo in how-to-deploy-a-django-application-on-aws
b1f53aa
@pulumi-bot
Copy link
Collaborator

Your site preview for commit b1f53aa is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13011-b1f53aab.s3-website.us-west-2.amazonaws.com.

@t0yv0
Fix documentation in component-resources/index.md
11356e1 
Although not specific to the BucketV2 transition, the examples needed some edits to pass `pulumi preview`.
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 11356e1 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13011-11356e15.s3-website.us-west-2.amazonaws.com.

@t0yv0
Improve copy-paste ability of examples in encapsulation/index.md
3ce8e86 
These seem to work with BucketV2. `pulumi preview` with these small changes is easier to work OOTB.
@t0yv0
Copy link
Member Author

t0yv0 commented Nov 8, 2024

Done additional manual checks on edited examples via pulumi preview. @sean1588 - had to back one out and added a few small fixes, PTAL.

** DONE review_project.md
** DONE languages-sdks/python
** DONE languages-sdks/yaml
** DONE packages-and-automation/continuous-delivery
** DONE pulumi-cloud/insights/export.md
** DONE pulumi-cloud/insights/search.md
** DONE pulumi-cloud/reference/cloud-rest-api
** DONE migrate/terraform.md
** DONE resources/how-to-deploy-a-django
** DONE tutorials/abstration-encapsulation/component-resources/index.md
** DONE tutorials/abstration-encapsulation/encapsulation/index.md
** DONE tutorials/abstration-encapsulation/stack-outputs-and-references/index.md
** DONE what-is/guide-to-automating-
** DONE what-is/what-is-yaml

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 3ce8e86 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13011-3ce8e86b.s3-website.us-west-2.amazonaws.com.

sean1588
sean1588 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again @t0yv0 ❤️

@t0yv0 t0yv0 merged commit b256390 into master Nov 9, 2024
8 checks passed
@t0yv0 t0yv0 deleted the t0yv0/update-to-bucketv2 branch November 9, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean1588 sean1588 sean1588 approved these changes

Assignees

@t0yv0 t0yv0

Labels
None yet
Projects
None yet
Milestone
0.112
Development

Successfully merging this pull request may close these issues.
4 participants
@t0yv0 @pulumi-bot @sean1588 @mjeffryes