Use declare keyword in TS example for dynamic resource outputs.
#13146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoward
added
kind/bug
|
Your site preview for commit 2f49a0c is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13146-2f49a0cc.s3-website.us-west-2.amazonaws.com. |
|
ping @justinvp . would love to get a technical review here. |
justinvp
reviewed
Oct 29, 2024
There was a problem hiding this comment.
I'm not convinced this is necessary. None of our generated provider SDKs use declare. I've asked about it at #11639 (comment)
|
Gonna close this until we figure out if its necessary or not. Can reopen if we determine it's needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: #11639 and #13132 ... this should be using
declare.