Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/11777 min requirements #13662

Merged
merged 15 commits into from
Dec 19, 2024
Merged

Conversation

GeoffMillerAZ
Copy link
Contributor

Proposed changes

Add minimum recommended requirements for the Pulumi cli.

I build https://github.com/pulumi/pulumi-benchmarking

it uses python and ts to build the same project. I used a json file to represent a typical structure that a pulumi project might see. That is, a sets of resources with dependencies that build a dependency tree. Because not all resources can build at once. This json file is used to make it easy to reproduce the same thing across runtimes. I currently have it implemented in ts and python. I also have it so you can do multiple of these trees on the same project. Right now I have it hard-coded at 2 of these trees. I will also make it so you can set a max number of resources that it will stop doing across the number of trees you give so you can limit the size for whatever reason. So number of buckets and number or resources are the 2 variables that give you the ability to quickly resize this test.

See the screenshot for a mermaid diagram of how each tree looks like for dependencies.

I used activity monitor just casually and an up got to 10% CPU on my m1 macbook pro. And it got to like 1.5GB of RAM. The destroy got to 20% and same RAM. It's 750MB disk space.

Unreleased product version (optional)

Related issues (optional)

#11777

…t hook tests require. This should reduce the headache by supplying automatic compliance to anyone having that feature enabled in their IDE
…se for working on the project that create unwanted artifacts
…cations to pulumi organizations that can be created with each type of sso protocol
…cations to pulumi organizations that can be created with each type of sso protocol
@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@thoward thoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for knocking this older issue out, @GeoffMillerAZ! Fixed a few things (see note about additional files in PR) and now it's ready for merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on my comment on your last PR, this should be the only file in this PR.

I will remove all the extra files in order to get this merged, but in the future it would be helpful to ensure PRs have a clean separation of concerns, following the single-responsibility principle.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@GeoffMillerAZ GeoffMillerAZ merged commit 2aa4579 into master Dec 19, 2024
8 checks passed
@GeoffMillerAZ GeoffMillerAZ deleted the feature/11777-min-requirements branch December 19, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants