Make external links open in new tabs #15025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add IndexNow API implementation in scripts/search/indexnow.js - Create shell wrapper in scripts/search/submit-indexnow.sh - Integrate with build pipeline in ci-push.sh - Add Makefile target for manual submission - Include API key in GitHub workflow environment - Add test scripts to verify API functionality This implementation submits new and updated URLs to search engines via the IndexNow protocol, allowing for faster indexing of content.
…ehavior - Add new external-links.ts script to identify external links - Add target='_blank' to external links only - Add rel='noopener' for security - Import the new script in main.ts - Keep internal navigation behavior unchanged
|
Your site preview for commit c8ffa96 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15025-c8ffa96a.s3-website.us-west-2.amazonaws.com. |
thoward
requested changes
May 14, 2025
There was a problem hiding this comment.
@asafashirov This PR seems to include two different changes: IndexNow and also external link behavior changes. Can you split these into separate PRs?
asafashirov
added a commit
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation
Test plan