Improve deprecation warning for Record.Value #1015
Open
+48
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1015 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 2 2
Lines 4 4
======================================
Misses 4 4 ☔ View full report in Codecov by Sentry. |
guineveresaenger
force-pushed
the
guin/override-deprecation-warning
branch
from
c660c43 to
fbb942d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In partial assist for #952.
Due to not having a reliable repro of #952, we update the deprecation warning on Record.Value to be more explicit about updating to the new field.
This pull request is blocked on the next bridge release as it needs changes from pulumi/pulumi-terraform-bridge#2746.