Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-databricks to v1.62.1 #691

Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 3, 2025

This PR was generated via $ upgrade-provider pulumi/pulumi-databricks --kind=provider.


This PR adds a manual patch to work around an issue with a parameter named Input which causes a class name clash in C sharp.
This was added instead of a rename does not work due to pulumi/pulumi-terraform-bridge#2803
The pu/pu issue for the problem is pulumi/pulumi#17826

@VenelinMartinov VenelinMartinov added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Does the PR have any schema changes?

Found 16 breaking changes:

Functions

  • 🟡 "databricks:index/getNotificationDestinations:getNotificationDestinations": inputs: "notificationDestinations" missing input "notificationDestinations"

Types

  • 🟡 "databricks:index/PipelineRestartWindow:PipelineRestartWindow": properties: "daysOfWeek" missing
  • "databricks:index/getFunctionsFunction:getFunctionsFunction": properties:
    • 🟡 "inputParams" type changed from "#/types/databricks:index/getFunctionsFunctionInputParams:getFunctionsFunctionInputParams" to "array":
      • 🟡 items had no type but now has &{Type: Ref:#/types/databricks:index/getFunctionsFunctionInputParam:getFunctionsFunctionInputParam AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
    • 🟡 "returnParams" type changed from "#/types/databricks:index/getFunctionsFunctionReturnParams:getFunctionsFunctionReturnParams" to "array":
      • 🟡 items had no type but now has &{Type: Ref:#/types/databricks:index/getFunctionsFunctionReturnParam:getFunctionsFunctionReturnParam AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
    • 🟡 "routineDependencies" type changed from "#/types/databricks:index/getFunctionsFunctionRoutineDependencies:getFunctionsFunctionRoutineDependencies" to "array":
      • 🟡 items had no type but now has &{Type: Ref:#/types/databricks:index/getFunctionsFunctionRoutineDependency:getFunctionsFunctionRoutineDependency AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
  • 🔴 "databricks:index/getFunctionsFunctionInputParams:getFunctionsFunctionInputParams" missing
  • 🔴 "databricks:index/getFunctionsFunctionInputParamsParameter:getFunctionsFunctionInputParamsParameter" missing
  • 🔴 "databricks:index/getFunctionsFunctionReturnParams:getFunctionsFunctionReturnParams" missing
  • 🔴 "databricks:index/getFunctionsFunctionReturnParamsParameter:getFunctionsFunctionReturnParamsParameter" missing
  • 🔴 "databricks:index/getFunctionsFunctionRoutineDependencies:getFunctionsFunctionRoutineDependencies" missing
  • 🔴 "databricks:index/getFunctionsFunctionRoutineDependenciesDependency:getFunctionsFunctionRoutineDependenciesDependency" missing
  • 🔴 "databricks:index/getFunctionsFunctionRoutineDependenciesDependencyFunction:getFunctionsFunctionRoutineDependenciesDependencyFunction" missing
  • 🔴 "databricks:index/getFunctionsFunctionRoutineDependenciesDependencyTable:getFunctionsFunctionRoutineDependenciesDependencyTable" missing

New resources:

  • index/app.App
  • index/credential.Credential

New functions:

  • index/getApp.getApp
  • index/getApps.getApps
  • index/getMwsNetworkConnectivityConfig.getMwsNetworkConnectivityConfig
  • index/getMwsNetworkConnectivityConfigs.getMwsNetworkConnectivityConfigs
  • index/getRegisteredModelVersions.getRegisteredModelVersions
  • index/getServingEndpoints.getServingEndpoints

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 1.91%. Comparing base (a114b42) to head (c6d915d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
provider/resources.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #691      +/-   ##
========================================
- Coverage   1.96%   1.91%   -0.06%     
========================================
  Files          4       4              
  Lines        254     261       +7     
========================================
  Hits           5       5              
- Misses       249     256       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov requested a review from a team January 3, 2025 15:05
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for unblocking this release.

Before we merge, can we file a patch tracking issue that re-iterates why this patch was added and follows the conditions needed to remove it? Thank you!

@VenelinMartinov
Copy link
Contributor Author

#692

@VenelinMartinov VenelinMartinov merged commit 7bee987 into main Jan 3, 2025
23 of 25 checks passed
@VenelinMartinov VenelinMartinov deleted the upgrade-terraform-provider-databricks-to-v1.62.1 branch January 3, 2025 17:10
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v1.57.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants