Skip to content

Commit

Permalink
Remove unused npm dependencies (#914)
Browse files Browse the repository at this point in the history
It looks like these dependencies aren't actually used anywhere, so stop
depending on them.

The motivation for this change is that the dependency on `resolve`
causes errors to be logged in logs during plugin discovery, because the
package includes tests that have malformed `package.json` files. If we
don't actually need the dependency it'd be nice to remove it so those
errors are no longer logged (so users don't [ask us about
them](pulumi/pulumi#17578)).

Also remove `read-package-tree` since it is deprecated.

Also remove `builtin-modules` since it doesn't appear to be used either.

Similar to pulumi/pulumi-aws#3238,
pulumi/pulumi-aws#4971, and
pulumi/pulumi-gitlab#786
Reference: pulumi/pulumi#17578
  • Loading branch information
justinvp authored Dec 23, 2024
1 parent 183eb3b commit a07ad0d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
5 changes: 0 additions & 5 deletions provider/cmd/pulumi-resource-digitalocean/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,6 @@
"nodejs": {
"packageDescription": "A Pulumi package for creating and managing DigitalOcean cloud resources.",
"readme": "\u003e This provider is a derived work of the [Terraform Provider](https://github.com/digitalocean/terraform-provider-digitalocean)\n\u003e distributed under [MPL 2.0](https://www.mozilla.org/en-US/MPL/2.0/). If you encounter a bug or missing feature,\n\u003e first check the [`pulumi-digitalocean` repo](https://github.com/pulumi/pulumi-digitalocean/issues); however, if that doesn't turn up anything,\n\u003e please consult the source [`terraform-provider-digitalocean` repo](https://github.com/digitalocean/terraform-provider-digitalocean/issues).",
"dependencies": {
"builtin-modules": "3.0.0",
"read-package-tree": "^5.2.1",
"resolve": "^1.7.1"
},
"devDependencies": {
"@types/node": "^10.0.0"
},
Expand Down
5 changes: 0 additions & 5 deletions provider/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -631,11 +631,6 @@ func Provider() tfbridge.ProviderInfo {
"digitalocean_reserved_ipv6": {Docs: &info.Doc{AllowMissing: true}},
},
JavaScript: &tfbridge.JavaScriptInfo{
Dependencies: map[string]string{
"builtin-modules": "3.0.0",
"read-package-tree": "^5.2.1",
"resolve": "^1.7.1",
},
DevDependencies: map[string]string{
"@types/node": "^10.0.0", // so we can access strongly typed node definitions.
},
Expand Down
5 changes: 1 addition & 4 deletions sdk/nodejs/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a07ad0d

Please sign in to comment.