Fix urn name clash for ReservedIp resource in DigitalOcean provider #515
Conversation
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
/run-acceptance-tests |
|
Please view the PR build: https://github.com/pulumi/pulumi-digitalocean/actions/runs/6669908001 |
|
Hi @lbialy - this is the current correct approach for disambiguation, so thank you for sending this PR. We would like to have a bit more background into this change. Can you add a more detailed PR description as to why this disambiguation is necessary; and how the resource behaves without it? Is there an issue describing this as a bug, with a repro? Please also add the name of the resource to the PR title. :) Thank you so much! |
lbialy
changed the title
|
Hi Guinevere, I've created #528 with rationale for this change and added resource name to the name of the PR. I have no idea how ReservedIp works right now with the clash in other language sdks and I believe the behaviour depends on the implementation of given SDK strongly. There's #352 in which ReservedIp seems to create a problem and it kinda makes sense that urn clash could lead to this for instance. For pulumi-scala this leads to a) duplicate urn fields generated which crash in Scala compilation (no duplicate fields allowed by compiler) and b) to codegen crash in newer versions that detect duplicates including reserved keywords like urn and id. |
|
@lbialy Thank you for your PR! You would need to run the full codegen and see the change percolate into all language SDKs. |
|
Would |
To regenerate the schema, you should use |
|
PR is now waiting for a maintainer to run the acceptance tests. |
Rebased copy of #515. I have checked with Platform, and they confirm that `urn` and `id` are reserved for their use. --------- Co-authored-by: Łukasz Biały <[email protected]>
|
This merged as part of #547. |
I'm not sure if this solves the whole thing but it seems all the other DO resources that have an URN field use this trick to rename it in generated schema.