Skip to content

Commit

Permalink
Skip template tests on .NET 6.0 image (#320)
Browse files Browse the repository at this point in the history
Our templates have been updated to use .NET 8.0, so they won't run
anymore on .NET 6.0.
  • Loading branch information
julienp authored Nov 13, 2024
1 parent 3a9c1e5 commit 5d9bc66
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,7 @@ jobs:
docker run \
-e RUN_CONTAINER_TESTS=true \
-e IMAGE_VARIANT=pulumi-debian-${{ matrix.sdk }} \
-e LANGUAGE_VERSION=${{ matrix.language_version }} \
-e SDKS_TO_TEST=${SDKS_TO_TEST} \
-e PULUMI_ACCESS_TOKEN=${PULUMI_ACCESS_TOKEN} \
-e PULUMI_ORG=${PULUMI_ORG} \
Expand Down Expand Up @@ -528,6 +529,7 @@ jobs:
docker run \
-e RUN_CONTAINER_TESTS=true \
-e IMAGE_VARIANT=pulumi-ubi-${{ matrix.sdk }} \
-e LANGUAGE_VERSION=${{ matrix.language_version }} \
-e SDKS_TO_TEST=${SDKS_TO_TEST} \
-e PULUMI_ACCESS_TOKEN=${PULUMI_ACCESS_TOKEN} \
-e PULUMI_ORG=${PULUMI_ORG} \
Expand Down
10 changes: 8 additions & 2 deletions tests/containers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ func TestPulumiTemplateTests(t *testing.T) {

stackOwner := mustEnv(t, "PULUMI_ORG")

languageVersion := os.Getenv("LANGUAGE_VERSION") // Not set for kitchen sink

sdksToTest := []string{"csharp", "python", "typescript", "go", "java"}
if os.Getenv("SDKS_TO_TEST") != "" {
sdksToTest = strings.Split(os.Getenv("SDKS_TO_TEST"), ",")
Expand All @@ -80,10 +82,14 @@ func TestPulumiTemplateTests(t *testing.T) {

testCases := []testCase{}
for _, sdk := range sdksToTest {
// python, typescript, ...
if sdk == "csharp" && languageVersion == "6.0" {
// .NET 6.0 is not supported by our templates anymore.
continue
}
// Base language templates: python, typescript, ...
testCases = append(testCases, testCase{sdk, map[string]string{}})
for _, cloud := range clouds {
// azure-python, aws-python, ...
// Cloud templates azure-python, aws-python, ...
if sdk == "typescript" && cloud == "azure" {
// We use docker & qemu to run arm64 images, and azure seems to be too large
// to successfully run in that environment.
Expand Down

0 comments on commit 5d9bc66

Please sign in to comment.