Revert "add oracle cloud cli to image (#182)" #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ddce061. Installing the Oracle CLI the way we're installing it is causing `/root/.bashrc` to be modified to include `/usr/bin` (the location where the `oci` binary is placed) at the front of `PATH`, _before_ `/usr/local/bin`. This ends up breaking `python3 -m venv venv` called from Pulumi Deployments because it ends up using the system Python at `/usr/bin/python3` rather than the version of Python from this image that should be used at `/usr/local/bin/python3` (due to the `PATH` change in `.bashrc`), and the system Python does not have `venv` available. It may be possible to address this by installing the Oracle CLI binary in `/usr/local/bin` rather than `/usr/bin`, but I'd like to see if it's possible to install the Oracle CLI without updating `.bashrc` at all, so reverting this in the meantime.
lunaris
approved these changes
May 24, 2024
github-merge-queue bot
pushed a commit
to pulumi/pulumi
that referenced
this pull request
May 24, 2024
To be merged after: - #16261 - pulumi/pulumi-docker-containers#195 Tentative changelog... ### Features - [engine] Guess ID references of dependant resources when generating code for import operations [#16208](#16208) ### Bug Fixes - [engine] Check property dependencies and deleted-with relationships for target dependents [#16220](#16220) - [engine] Propagate dependencies of untargeted resources correctly during targeted updates [#16247](#16247) - [backend/diy] Rewrite DeletedWith references when renaming stacks [#16216](#16216) - [cli/state] Fix state renames involving DeletedWith - [sdk/python] Use a separate type variable for static methods on Output [#16172](#16172) - [sdk/python] Relax Output.all types to better match the implementation [#16172](#16172) - [sdkgen/python] Generate __init__.py files for modules that only contain enumerations [#16229](#16229)
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ddce061.
Installing the Oracle CLI the way we're installing it is causing
/root/.bashrcto be modified to include/usr/bin(the location where theocibinary is placed) at the front ofPATH, before/usr/local/bin.This ends up breaking
python3 -m venv venvcalled from Pulumi Deployments because it ends up using the system Python at/usr/bin/python3rather than the version of Python from this image that should be used at/usr/local/bin/python3(due to thePATHchange in.bashrc), and the system Python does not havevenvavailable.It may be possible to address this by installing the Oracle CLI binary in
/usr/local/binrather than/usr/bin, but I'd like to see if it's possible to install the Oracle CLI without updating.bashrcat all, so reverting this in the meantime.Fixes #193