Set shell options during docker builds #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
added
the
impact/no-changelog-required
Set stricter options for shell commands, particulary `pipefail` so that commands like `curl … | bash` fail the build when the curl download fails. Without this option, the shell will only consider the exit code of the last command in the pipeline, which might erroneously succeed.
julienp
force-pushed
the
julienp/shell
branch
from
fab03c7 to
f2561b6
Compare
|
My docker setup locally is broken right now, so I can't test it, but wouldn't this affect the default shell for users as well, and they would get different behaviour of the shell than they would expect normally? |
Indeed it does. Maybe instead we should just set these options for specific steps, for example RUN set -exo pipefail && curl ... | sh |
|
One option would be to reset the shell to just be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set stricter options for shell commands, particulary
pipefailso that commands likecurl ... | shfail the build when the curl download fails. Without this option, the shell will only consider the exit code of the last command in the pipeline, which might erroneously succeed.Our tests typically catch builds of bad images like this, but it can be confusing to debug the test failures. Let's make sure we fail as early as possible.