Update to redhat/ubi9 for UBI based images #342
Merged
+20
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
force-pushed
the
julienp/ubi-9
branch
from
dd5ff1d to
fb49a6f
Compare
tgummerer
reviewed
Dec 17, 2024
| @@ -399,6 +399,10 @@ func TestEnvironment(t *testing.T) { | |||
| if imageVariant == "pulumi" { | |||
| expectedPath += ":/root/.pulumi/bin" | |||
| } | |||
| // When running in bash, the UBI images include /root/.local/bin:/root/bin: | |||
There was a problem hiding this comment.
Is this intentional, or de we need to exclude these? Does this pull in any additional binaries for the user that might not be expected?
There was a problem hiding this comment.
This is a change in the UBI9 images, the stock bashrc now includes:
# User specific environment
if ! [[ "$PATH" =~ "$HOME/.local/bin:$HOME/bin:" ]]
then
PATH="$HOME/.local/bin:$HOME/bin:$PATH"
fi
export PATH
This seems OK to me. We have tests for the binaries we provide to ensure they are at the path we expect, and there are no binaries in these folders in our images. Users would have to explicitly install something, which I think makes this ok.
I'd also rather not make the images behave too differently from stock UBI9 for users by changing the default bashrc.
tgummerer
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UBI8 is EOL https://endoflife.date/rhel
Fixes #338