Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable accurate bridge previews by default #840

Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jan 2, 2025

This enables the Accurate Previews bridge feature for the pulumi-github provider. This should improve the quality of our previews for the provider.

It also updates the GRPC test to match the new behaviour.

Part of pulumi/pulumi-terraform-bridge#2598

@VenelinMartinov VenelinMartinov requested a review from a team January 2, 2025 17:55
@VenelinMartinov VenelinMartinov added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d841c23) to head (bdbba92).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #840   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines           6       6           
======================================
  Misses          6       6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov enabled auto-merge (squash) January 2, 2025 18:08
@VenelinMartinov VenelinMartinov merged commit e29565b into master Jan 2, 2025
25 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/enable_accurate_bridge_previews_by_default branch January 2, 2025 18:11
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.5.0.

@github-actions github-actions bot removed the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants