Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional properties schema #60

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Additional properties schema #60

merged 2 commits into from
Jan 2, 2025

Conversation

rshade
Copy link
Contributor

@rshade rshade commented Dec 30, 2024

This removes additionalProperties on some of the schema, so that it rewrites the types. It should fix #22, fix #24

Copy link

github-actions bot commented Dec 30, 2024

Does the PR have any schema changes?

Found 4 breaking changes:

Types

  • "kubernetes-ingress-nginx:index:Controller": properties:
    • 🟡 "config": additional properties had &{Type:object Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false} but now has no type
    • 🟡 "configAnnotations": additional properties had &{Type:object Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false} but now has no type
    • 🟡 "dnsConfig": additional properties had &{Type:object Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false} but now has no type
    • 🟡 "extraArgs": additional properties had &{Type:object Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false} but now has no type
      No new resources/functions.

@rshade rshade force-pushed the additionalPropertiesSchema branch from d0c8b00 to d16d6a0 Compare December 30, 2024 21:36
@rshade rshade force-pushed the additionalPropertiesSchema branch 6 times, most recently from 368a2bc to ac6b9c3 Compare January 2, 2025 14:46
@rshade rshade force-pushed the additionalPropertiesSchema branch from ac6b9c3 to e447766 Compare January 2, 2025 14:47
@rshade rshade force-pushed the additionalPropertiesSchema branch from e447766 to 320bb63 Compare January 2, 2025 15:09
@rshade rshade merged commit 1b87b85 into master Jan 2, 2025
17 checks passed
@rshade rshade deleted the additionalPropertiesSchema branch January 2, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why controller.config and controller.configAnnotations are map of maps?
2 participants