Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accurate bridge previews rollout plan #2598

Open
1 of 5 tasks
VenelinMartinov opened this issue Nov 6, 2024 · 3 comments
Open
1 of 5 tasks

Accurate bridge previews rollout plan #2598

VenelinMartinov opened this issue Nov 6, 2024 · 3 comments
Labels
kind/engineering Work that is not visible to an external user

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Nov 6, 2024 •
edited
Loading

The rollout plan for accurate bridge previews is intended to follow what we did with the PlanResourceChange SDKv2 bridge feature #1785.

We will enable the accurate bridge previews feature for:

  • A tier 2 provider (cloudflare if it is suitable)
  • All tier 2 providers
  • Azure and GCP
  • AWS
  • Enabled by default in the bridge

In contrast to the PRC feature we might get less feedback from the rollout due to:

  • Provider tests generally don't test the preview output - these won't provide any feedback
  • This feature is less likely to break in obvious ways, like PRC did

We could opt for rolling out accurate bridge previews for the SDKv2 and PF separately. This means we could potentially start the rollout earlier at the cost of higher complexity. Currently this seems unlikely to be worthwhile.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Nov 6, 2024
@VenelinMartinov VenelinMartinov added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Nov 6, 2024
@t0yv0 t0yv0 mentioned this issue Dec 5, 2024
Open
@VenelinMartinov
Copy link
Contributor Author

We have decided not to roll out PF yet as we have a meaningful regression there which is currently blocked.

#2688 will track PF rollout separately

@VenelinMartinov VenelinMartinov mentioned this issue Jan 2, 2025
Merged
@VenelinMartinov
Copy link
Contributor Author

I'm going to start the rollout with pulumi-github as it has similar levels of usage as cloudflare but is entirely sdkv2

@VenelinMartinov VenelinMartinov mentioned this issue Jan 2, 2025
Merged
VenelinMartinov added a commit to pulumi/pulumi-github that referenced this issue Jan 2, 2025
@VenelinMartinov
Enable accurate bridge previews by default (#840)
e29565b 
This enables the Accurate Previews bridge feature for the pulumi-github
provider. This should improve the quality of our previews for the
provider.

It also updates the GRPC test to match the new behaviour.

Part of pulumi/pulumi-terraform-bridge#2598
@VenelinMartinov
Copy link
Contributor Author

pulumi-github was shipped with accurate bridge previews by default in https://github.com/pulumi/pulumi-github/releases/tag/v6.5.0

VenelinMartinov added a commit that referenced this issue Jan 6, 2025
@VenelinMartinov
Add a separate PF accurate previews feature flag (#2808)
2150faf 
We've decided to postpone rolling out PF accurate previews, so the SDKv2
bridge and the PF bridge need separate feature flags. This change adds a
new feature flag for PF and keeps the old one for the SDKv2.

related to #2598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/engineering Work that is not visible to an external user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VenelinMartinov @pulumi-bot