Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document versioning practices for dynamic package #2809

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

guineveresaenger
Copy link
Contributor

Followup for pulumi/pulumi-terraform-provider#54.

Clarifies where and how we're linking in the version to the dynamic binary.

@guineveresaenger guineveresaenger requested a review from a team January 3, 2025 19:09
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.62%. Comparing base (8062afe) to head (9731b53).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
- Coverage   68.74%   68.62%   -0.12%     
==========================================
  Files         325      325              
  Lines       41536    41536              
==========================================
- Hits        28554    28505      -49     
- Misses      11376    11426      +50     
+ Partials     1606     1605       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit, then LGTM.

dynamic/version/version.go Outdated Show resolved Hide resolved
@guineveresaenger guineveresaenger merged commit 960b71c into master Jan 8, 2025
17 checks passed
@guineveresaenger guineveresaenger deleted the guin/document-versioning-dynamic branch January 8, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants