Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Use MultiSelector's UnselectAll() method instead of iterating over … #486

Merged

Conversation

BerndHaidan
Copy link
Contributor

…the collection with items to deselect; This increases the performance significant!

e.g. for a DataGrid with 5.000 rows from > 3s to < 20ms

What changed?

Extension Method SetSelectedItem in ItemsControlExtensions.cs is adapted.
Instead collect items to deselect and iterating over this collection, use UnselectAll() method.

To demonstrate the difference the DataGrid Sample is modified too.

An issue wasn't open yet.

…the collection with items to deselect; This increases the performance significant!

e.g. for a DataGrid with 5.000 rows from >3s to < 20ms
@punker76 punker76 added this to the 4.0.0 milestone Mar 14, 2024
@punker76 punker76 merged commit 22dfca8 into punker76:develop Mar 14, 2024
3 checks passed
@punker76
Copy link
Owner

@BerndHaidan your changes have been merged, thanks for your contribution 👍

@BerndHaidan
Copy link
Contributor Author

Was a pleasure. 😊
Thanks for publishing this really helpful library. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants