-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Microsoft Azure Linux to Facter 4.x #2723
Conversation
Add support for Microsoft Azure Linux, prevously known as CBL-Mariner, Microsoft's Linux distribution for cloud infrastructure and edge products and services.
Can one of the admins verify this patch? |
|
||
[Facter::ResolvedFact.new(FACT_NAME, version), | ||
Facter::ResolvedFact.new(ALIASES.first, version['major'], :legacy), | ||
Facter::ResolvedFact.new(ALIASES.last, version['full'], :legacy)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add support for minor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still an open question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're actually getting minor in the facter output already, but I'm not sure how that's working.
'Mariner', | ||
'Azurelinux' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, but shouldn't both Mariner and AzureLinux be nested under Rhel (line 20)?
This looks good to me other than the hierarchy in |
Add support for Microsoft Azure Linux, previously known as CBL-Mariner, Microsoft's Linux distribution for cloud infrastructure and edge products and services.
Before:
After:
Fixes #2727