Allow facter test log to be written to a file #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the FACTER_TEST_LOG environment variable is set, then use it as the log
destination when running facter tests. This is borrowed from puppet's
PUPPET_TEST_LOG. The test file path and line number are written so you can tell
which test generated the log output:
I, [2024-05-20T16:26:04.852790 #3073378] INFO -- : *** BEGIN TEST ./spec/custom_facts/core/execution_spec.rb:63
I, [2024-05-20T16:26:04.853239 #3073378] INFO -- : *** BEGIN TEST ./spec/custom_facts/core/execution_spec.rb:71
W, [2024-05-20T16:26:04.853473 #3073378] WARN -- : Facter::Core::Execution::Posix - Unexpected key passed to Facter::Core::Execution.execute option: time_limit - valid keys: on_fail,expand,logger,timeout
I, [2024-05-20T16:26:04.853680 #3073378] INFO -- : *** BEGIN TEST ./spec/custom_facts/core/execution_spec.rb:71
cthorn42
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the FACTER_TEST_LOG environment variable is set, then use it as the log
destination when running facter tests. This is borrowed from puppet's
PUPPET_TEST_LOG. The test file path and line number are written so you can tell
which test generated the log output: