Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-3483) Temporarily pin sys-filesystem to <= 1.5.0 to resolve jruby integration check failure #2765

Merged
merged 1 commit into from
Oct 3, 2024
Merged

(FACT-3483) Temporarily pin sys-filesystem to <= 1.5.0 to resolve jruby integration check failure #2765

merged 1 commit into from
Oct 3, 2024

Conversation

AriaXLi
Copy link
Contributor

@AriaXLi AriaXLi commented Oct 2, 2024

No description provided.

@AriaXLi AriaXLi force-pushed the maint/jruby_ubuntu_integration_failure branch from 02f7cba to 7e3f022 Compare October 2, 2024 22:07
@AriaXLi AriaXLi changed the title WIP (FACT-3483) Temporarily pin sys-filesystem to 1.5.0 to resolve jruby integration check failure Oct 2, 2024
@AriaXLi AriaXLi marked this pull request as ready for review October 2, 2024 22:09
@AriaXLi AriaXLi requested a review from a team as a code owner October 2, 2024 22:09
@AriaXLi
Copy link
Contributor Author

AriaXLi commented Oct 2, 2024

This should be reverted once FACT-3483 is resolved.

@AriaXLi AriaXLi force-pushed the maint/jruby_ubuntu_integration_failure branch from 7e3f022 to 3b0d271 Compare October 2, 2024 22:52
@AriaXLi AriaXLi changed the title (FACT-3483) Temporarily pin sys-filesystem to 1.5.0 to resolve jruby integration check failure (FACT-3483) Temporarily pin sys-filesystem to <= 1.5.0 to resolve jruby integration check failure Oct 2, 2024
@mhashizume
Copy link
Contributor

Could it make sense to keep 1.4 as the minimum version for now?

@AriaXLi AriaXLi force-pushed the maint/jruby_ubuntu_integration_failure branch from 3b0d271 to 121f276 Compare October 2, 2024 23:38
@AriaXLi
Copy link
Contributor Author

AriaXLi commented Oct 2, 2024

Could it make sense to keep 1.4 as the minimum version for now?

Yeah that makes sense to me!

@AriaXLi
(FACT-3483) Temporarily pin sys-filesystem to >= 1.4.0, <= 1.5.0
fea813c 
This commit pins sys-filesystem to resolve the failing integration
ubuntu-22.04 jruby-9.3.14.0 check and also allow sys-filesystem 1.4.4 which we
ship in puppet-runtime. This should be reverted once FACT-3483 is resolved.
@AriaXLi AriaXLi force-pushed the maint/jruby_ubuntu_integration_failure branch from 121f276 to fea813c Compare October 2, 2024 23:39
@mhashizume mhashizume merged commit 92a6484 into puppetlabs:main Oct 3, 2024
18 checks passed
AriaXLi added a commit to AriaXLi/facter that referenced this pull request Oct 10, 2024
@AriaXLi
Revert "Merge pull request puppetlabs#2765 from AriaXLi/maint/jruby_u…
f4b5e62 
…buntu_integration_failure"

This reverts commit 92a6484, reversing
changes made to bbb2d35.

Previously, sys-filesystem 1.5.2 caused some integration check failures,
but after the release of sys-filesystem 1.5.3, these failures went away.
@joshcooper joshcooper added the maintenance Maintenance chores are excluded from changelogs label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhashizume mhashizume mhashizume approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AriaXLi @mhashizume @joshcooper