Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-6427) Add rake tasks for building nightly gem #9364

Merged
merged 2 commits into from
May 29, 2024

Conversation

joshcooper
Copy link
Contributor

Adds pl_ci:nightly_gem_build The only difference from gem_build is that the nightly version uses the extended dot version as the version string in the gemspec (and therefore resulting filename). Based on puppetlabs/facter#2726

@joshcooper joshcooper changed the title Nightly gems (PA-6427) Add rake tasks for building nightly gem May 24, 2024
Change the parameter from `s` to `spec`

Remove version matching that only used the x.y.z and ignored the rest

Fix indentation
@joshcooper joshcooper marked this pull request as ready for review May 25, 2024 00:19
@joshcooper joshcooper requested a review from a team as a code owner May 25, 2024 00:19
@joshcooper joshcooper marked this pull request as draft May 28, 2024 15:35
@joshcooper joshcooper marked this pull request as ready for review May 29, 2024 05:06
@joshcooper joshcooper added the maintenance Maintenance chores are excluded from changelogs label May 29, 2024
@joshcooper
Copy link
Contributor Author

After merging, please backport to 7.x

@mhashizume mhashizume merged commit b6e9c9b into puppetlabs:main May 29, 2024
10 checks passed
@mhashizume mhashizume added the backport 7.x Generate a backport PR to 7.x label May 29, 2024
Copy link

Backport failed for 7.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 7.x
git worktree add -d .worktree/backport-9364-to-7.x origin/7.x
cd .worktree/backport-9364-to-7.x
git checkout -b backport-9364-to-7.x
ancref=$(git merge-base 73e253a0cb7dfd3795b62bdbb7ef6feb377c30ed a587c459f7d5da67fb7cfa9afabb98e155fc33a9)
git cherry-pick -x $ancref..a587c459f7d5da67fb7cfa9afabb98e155fc33a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 7.x Generate a backport PR to 7.x maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants