-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release prep v4.20.1 #719
Release prep v4.20.1 #719
Conversation
was that raised by accident? |
@bastelfreak the previous attempt to push 4.20.0 failed so I think I need to burn the tag, I'll update the description |
Please don't delete the tag or recreate it. We did that in the past and it's horrible for people that already have the tag locally. For situations like that at vox pupuli we create an issue that explains it in the title. Nice hack to get a note into the changelog. Maybe that works for you as well. |
yeah we never delete tags or recreate them. Our changelog generator only looks at pull requests that have been merged since the last tag, so I don't know how to indicate what happened in the changelog (without making code changes). |
@bastelfreak are you ok with this approach? |
Yes I think that's totally fine! |
Never tried with GitHub, but maybe worth trying next time:
If adding a commit without change in a PR and merging it does the right thing, this should allow the ChangeLog to have some content while the code is actually unchanged (but still has the commit message that explain why this was done in the repo). |
The previous attempt to release 4.20.0 failed, so burning the tag and prepping 4.20.1:
Automated release-prep through pdk-templates from commit 35bf03f.
Please verify before merging: