Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep v4.20.1 #719

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Release prep v4.20.1 #719

merged 1 commit into from
Jun 3, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented May 29, 2024

The previous attempt to release 4.20.0 failed, so burning the tag and prepping 4.20.1:

Automated release-prep through pdk-templates from commit 35bf03f.
Please verify before merging:

@github-actions github-actions bot added the maintenance Maintenance chores are typically excluded from changelogs label May 29, 2024
@github-actions github-actions bot requested review from bastelfreak and a team as code owners May 29, 2024 18:23
@bastelfreak
Copy link
Collaborator

was that raised by accident?

@joshcooper
Copy link
Contributor

@bastelfreak the previous attempt to push 4.20.0 failed so I think I need to burn the tag, I'll update the description

@joshcooper joshcooper closed this May 29, 2024
@joshcooper joshcooper reopened this May 29, 2024
@bastelfreak
Copy link
Collaborator

Please don't delete the tag or recreate it. We did that in the past and it's horrible for people that already have the tag locally. For situations like that at vox pupuli we create an issue that explains it in the title. Nice hack to get a note into the changelog. Maybe that works for you as well.

@joshcooper
Copy link
Contributor

yeah we never delete tags or recreate them. Our changelog generator only looks at pull requests that have been merged since the last tag, so I don't know how to indicate what happened in the changelog (without making code changes).

@joshcooper
Copy link
Contributor

@bastelfreak are you ok with this approach?

@bastelfreak
Copy link
Collaborator

Yes I think that's totally fine!

@joshcooper joshcooper merged commit 855c3f0 into main Jun 3, 2024
17 checks passed
@joshcooper joshcooper deleted the release-prep branch June 3, 2024 15:51
@smortex
Copy link
Contributor

smortex commented Jun 3, 2024

Our changelog generator only looks at pull requests that have been merged since the last tag, so I don't know how to indicate what happened in the changelog (without making code changes).

Never tried with GitHub, but maybe worth trying next time:

git commit --allow-empty

If adding a commit without change in a PR and merging it does the right thing, this should allow the ChangeLog to have some content while the code is actually unchanged (but still has the commit message that explain why this was done in the repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants