SUP-4604 - Deprecation of primary_server_port_check task [st1105] #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyEwings
added
enhancement
MartyEwings
requested changes
Nov 10, 2023
MartyEwings
requested changes
Nov 10, 2023
MartyEwings
reviewed
Nov 10, 2023
Aaronoftheages
force-pushed
the
SUP-4604_Deprecation_Primary_Server_port_checK_task_st1105
branch
2 times, most recently
from
6069da3
to
134ba2d
Compare
m0dular
suggested changes
Nov 10, 2023
Aaronoftheages
force-pushed
the
SUP-4604_Deprecation_Primary_Server_port_checK_task_st1105
branch
from
fab03ec
to
160c936
Compare
m0dular
suggested changes
Nov 10, 2023
There was a problem hiding this comment.
Please update the commit message to be in the expected format. It should be something like
(SUP-4604) Deprecate primary port check task
This commit deprecates the task to checks the status of the ports on the
primary Puppet server.
The general format is
(JIRA-KEY) A brief description
A longer description after a newline, if necessary.
We use this for Jira integration and generating the changelog. You can use git commit --amend since this is only one commit.
This commit deprecates the task to checks the status of the ports on the primary Puppet server and updates the readme.
Aaronoftheages
force-pushed
the
SUP-4604_Deprecation_Primary_Server_port_checK_task_st1105
branch
from
160c936
to
76d8c6b
Compare
MartyEwings
approved these changes
Nov 12, 2023
m0dular
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation Message addition to task ST1105 and Readme Update