Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs related to the creation of a new invoice #228

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

svenwey
Copy link
Collaborator

@svenwey svenwey commented Feb 18, 2025

Fixes the related bugs 63817, 63819, 63820 and then enabled by this fix, implements 63118 and 63119.

This essentially involves the following parts:

  • [63817, 63819, 63820] deactivating turbolinks for navigation between different tabs in orders, as this introduces buggy behaviour when using the back button of the browser
  • [63118] also passing the period_shortcut as param
  • [63119] adding a button to select a period_shortcut in the creation of a new invoice. Debug an existing race condition.

All these tickets are tightly connected, why I combine them in one PR. If these should be separated either way, I'm happy to do so.

@svenwey svenwey requested a review from Kagemaru February 18, 2025 13:21
@svenwey svenwey self-assigned this Feb 18, 2025
@svenwey svenwey changed the title Feature/63119 adopt timespan at invoice creation Fix various bugs related to the creation of a new invoice Feb 24, 2025
@svenwey svenwey requested review from daniel-illi and removed request for Kagemaru February 26, 2025 10:30
@svenwey svenwey requested a review from kronn March 5, 2025 07:16
@svenwey svenwey marked this pull request as draft March 6, 2025 10:20
@svenwey svenwey marked this pull request as ready for review March 6, 2025 12:09
Copy link
Member

@kronn kronn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good in general. I only want to see one simplification/correct usage of WithPeriod and the usual tests.

@svenwey svenwey requested a review from kronn March 11, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants