Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear individual timespan upon selection of predefined timeperiod (63863) #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svenwey
Copy link
Collaborator

@svenwey svenwey commented Feb 25, 2025

No description provided.

@svenwey svenwey requested a review from Kagemaru February 25, 2025 08:40
@svenwey svenwey self-assigned this Feb 25, 2025
@svenwey svenwey requested review from daniel-illi and removed request for Kagemaru February 26, 2025 10:29
@daniel-illi daniel-illi changed the title [63863] Clear individual timespan upon selection of predefined timeperiod [63863] Clear individual timespan upon selection of predefined timeperiod (63863) Feb 26, 2025
@daniel-illi daniel-illi changed the title [63863] Clear individual timespan upon selection of predefined timeperiod (63863) Clear individual timespan upon selection of predefined timeperiod (63863) Feb 26, 2025
@svenwey svenwey added the bug label Feb 28, 2025
@svenwey svenwey requested a review from kronn March 5, 2025 07:17
Copy link
Member

@kronn kronn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test that fails without this change? There are several integration-tests, which even handle selectize. For example: https://github.com/puzzle/puzzletime/blob/master/test/integration/create_ordertime_test.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants